-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read only consent management table and filters #4456
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #5429 ↗︎
Details:
Review all test suite changes for PR #4456 ↗︎ |
clients/admin-ui/src/features/system/add-multiple-systems/AddMultipleSystems.tsx
Show resolved
Hide resolved
I found a bug with the pagination, it seems like we might just need to reset the current page whenever the filter updates Steps to reproduce: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I called out a few places that need sentence-casing but the biggest issue is the pagination bug 🐞. I also started commenting with some style suggestions but I decided to just create another PR so you can review that and pull in whatever you agree with (borrowed the approach from @adamsachs, thanks Adam!)
clients/admin-ui/src/features/configure-consent/ConsentManagementFilterModal.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pagination bug is fixed, looks good to me!
I fixed what was addressed and the PR is saying a didn't
Closes PROD-1341
Description Of Changes
This adds a new consent management table view when TCF is enabled.
Code Changes
AddVendor
modal so the fields can be disabledSteps to Confirm
TCF Enabled
TCF-enabled.mov
consent/configure
TCF Disabled
consent/configure
Pre-Merge Checklist
CHANGELOG.md