Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1243- adds ability to provide custom fides overrides path #4462

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

eastandwestwind
Copy link
Contributor

Closes https://ethyca.atlassian.net/browse/PROD-1243

Description Of Changes

Adds ability to provide custom fides overrides path, e.g. "window.config.override_options". The default is now "window.fides_overrides" if this config var isn't provided.

Code Changes

  • Add new config var customOptionsPath
  • Adjust e2e tests

Steps to Confirm

  • Run e2e tests

Pre-Merge Checklist

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 5:45pm

Copy link

cypress bot commented Nov 27, 2023

Passing run #5490 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 297a33c into 5dab33f...
Project: fides Commit: a2b7ca5288 ℹ️
Status: Passed Duration: 00:33 💡
Started: Dec 5, 2023 5:55 PM Ended: Dec 5, 2023 5:55 PM

Review all test suite changes for PR #4462 ↗︎

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some non blocking suggestions!

clients/fides-js/src/lib/initialize.ts Outdated Show resolved Hide resolved
clients/fides-js/src/lib/consent-types.ts Show resolved Hide resolved
@eastandwestwind eastandwestwind merged commit e53d78a into main Dec 5, 2023
13 checks passed
@eastandwestwind eastandwestwind deleted the PROD-1243 branch December 5, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants