Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1480: Update logging level for 'Retrieved FidesUserPermission record for current user' message to Debug #4482

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Dec 4, 2023

Closes PROD-1480

Description Of Changes

Changes the log level of Retrieved FidesUserPermission record for current user message to DEBUG instead of INFO. When a user is browsing around the Admin UI, these logs show up almost every other line and make it harder to follow logs. They still have value, but I believe that DEBUG is a better level for them.

Code Changes

  • Change function from logger.info() to logger.debug()

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

@RobertKeyser RobertKeyser self-assigned this Dec 4, 2023
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 3:26pm

Copy link

cypress bot commented Dec 4, 2023

Passing run #5476 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 0cb610d into 05b5bfd...
Project: fides Commit: 3284eb2dee ℹ️
Status: Passed Duration: 00:33 💡
Started: Dec 5, 2023 3:37 PM Ended: Dec 5, 2023 3:38 PM

Review all test suite changes for PR #4482 ↗︎

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05b5bfd) 87.11% compared to head (0cb610d) 87.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4482   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files         331      331           
  Lines       20478    20478           
  Branches     2639     2639           
=======================================
  Hits        17839    17839           
  Misses       2172     2172           
  Partials      467      467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobertKeyser RobertKeyser marked this pull request as ready for review December 5, 2023 15:21
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobertKeyser RobertKeyser merged commit c7218f0 into main Dec 5, 2023
42 checks passed
@RobertKeyser RobertKeyser deleted the rkeyser/logging-prod-1480 branch December 5, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants