Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with retention period being 'null' on dictionary data uses #4487

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Dec 5, 2023

Closes #PROD-1202

Description Of Changes

Fixes a bug where, when a privacy declaration with "retention_period": null is populated from Compass, the UI populates "null" and saves it as a string literal.

Steps to Confirm

With Compass enabled:

  • Create a system with a GVL v2 vendor (I used "Rockerbox")
  • Go to "Data uses" tab
  • Should be populated automatically on save
  • Check "Retention period" field, verify that it's empty

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 7:52pm

Copy link

cypress bot commented Dec 5, 2023

Passing run #5502 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 6bf97c6 into c94a3ea...
Project: fides Commit: 60380a55b6 ℹ️
Status: Passed Duration: 00:33 💡
Started: Dec 5, 2023 8:01 PM Ended: Dec 5, 2023 8:02 PM

Review all test suite changes for PR #4487 ↗︎

@jpople jpople merged commit 31a3d34 into main Dec 5, 2023
13 checks passed
@jpople jpople deleted the jpople/prod-1202/null-retention-period-fix branch December 5, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants