-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Con 59 mg appsflyer connector #4512
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #5874 ↗︎
Details:
Review all test suite changes for PR #4512 ↗︎ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4512 +/- ##
==========================================
- Coverage 87.06% 87.04% -0.02%
==========================================
Files 334 335 +1
Lines 20554 20578 +24
Branches 2651 2653 +2
==========================================
+ Hits 17896 17913 +17
- Misses 2186 2193 +7
Partials 472 472 ☔ View full report in Codecov by Sentry. |
Tests are all passing, this looks okay to me, hopefully no gremlins got into the code over the holidays =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Just a few minor things. I can test this once you add the secrets to 1password, I can't find the entry for AppsFlyer.
Closes #CON-59
Description Of Changes
Adding a new Appsflyer Erasure Connector
Code Changes
Steps to Confirm
Pre-Merge Checklist
(https://github.com/ethyca/fidesdocs/pull/305)
(https://github.com/ethyca/fidesdocs/issues/304)
CHANGELOG.md