Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing condition for rendering overlay #4515

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Fixing condition for rendering overlay #4515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2d1e72
Fixing condition for rendering overlay
galvana Dec 14, 2023
62612f7
Merge branch 'main' into PROD-1534-hide-blocking-overlay-on-return
galvana Dec 14, 2023
e7acfb4
Updating change log
galvana Dec 14, 2023
3661748
Merge branch 'main' into PROD-1534-hide-blocking-overlay-on-return
galvana Dec 18, 2023
0917fc9
Merge branch 'main' into PROD-1534-hide-blocking-overlay-on-return
galvana Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The types of changes are:
- Fixed incorrect Compass button behavior in system form [#4508](https://github.com/ethyca/fides/pull/4508)
- Omit certain fields from system payload when empty [#4508](https://github.com/ethyca/fides/pull/4525)
- Fixed issues with Compass vendor selector behavior [#4521](https://github.com/ethyca/fides/pull/4521)
- Fixed an issue where the background overlay remained visible after saving consent preferences [#4515](https://github.com/ethyca/fides/pull/4515)

### Changed
- Upgrade to use Fideslang `3.0.0` and remove associated concepts [#4502](https://github.com/ethyca/fides/pull/4502)
Expand Down
2 changes: 1 addition & 1 deletion clients/fides-js/src/components/Overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ const Overlay: FunctionComponent<Props> = ({

return (
<div>
{bannerIsOpen && window.Fides.options.preventDismissal && (
{showBanner && bannerIsOpen && window.Fides.options.preventDismissal && (
<div className="fides-modal-overlay" />
)}
{showBanner
Expand Down