Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locations modal #4531

Merged
merged 26 commits into from
Jan 3, 2024
Merged

Locations modal #4531

merged 26 commits into from
Jan 3, 2024

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Dec 20, 2023 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/PROD-1493

Description Of Changes

See overall loom in this PR: #4530

Code Changes

  • Add subgroup modal
  • Change location cards to only show locations that do not belong to another location ("parents")
  • Make subgroup modal show locations that do belong to another location ("children") UNLESS there are no subgroups (i.e. South America does not currently have subgroups)
  • Add some cascading behavior—if you select all of the locations inside "Canada", the "Canada" checkbox will toggle on too. If you deselect one of them, it will toggle off.
  • Fix the number selected badge to only count the number of "children" regions
  • Make search bring "children" regions up to the card level. This doesn't entirely work yet (if you click "Quebec", "Canada" will also get selected, but if you deselect "Canada", "Quebec" will not get deselected. I didn't implement that yet because I wanted to confirm with design that this is the intended behavior first
  • Cypress tests

Steps to Confirm

Pre-Merge Checklist

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 4:22pm

@cypress Cypress
Copy link

cypress bot commented Dec 20, 2023 •
edited
Loading

Passing run #5825 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 1870441 into 3d210dd...
Project: fides Commit: 50a0af7c61 ℹ️
Status: Passed Duration: 00:33 💡
Started: Jan 2, 2024 10:43 PM Ended: Jan 2, 2024 10:43 PM

Review all test suite changes for PR #4531 ↗︎

@allisonking allisonking removed the request for review from TheAndrewJackson December 20, 2023 16:39
@allisonking
Copy link
Contributor Author

Actually I'm unassigning @TheAndrewJackson for now since there are some adjustments that need to be made after meeting with Michael and Simon this morning!

@allisonking allisonking mentioned this pull request Jan 2, 2024
Merged
9 tasks
@allisonking allisonking marked this pull request as ready for review January 2, 2024 22:33
@allisonking allisonking removed the request for review from TheAndrewJackson January 2, 2024 22:37
Kelsey-Ethyca
Kelsey-Ethyca approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@allisonking allisonking merged commit d0785f0 into aking/prod-1491/locations-page Jan 3, 2024
8 of 9 checks passed
@allisonking allisonking deleted the aking/prod-1493/locations-modal branch January 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelsey-Ethyca Kelsey-Ethyca Kelsey-Ethyca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @Kelsey-Ethyca