-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update 'add vendor' flow #4550
update 'add vendor' flow #4550
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #5972 ↗︎
Details:
Review all test suite changes for PR #4550 ↗︎ |
cy.getByTestId("row-0").within(() => { | ||
cy.get('[type="checkbox"]').check({ force: true }); | ||
}); | ||
cy.get('[type="checkbox"').check({ force: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a workaround for some weird behavior with the previous .check()
not checking the checkbox-- none of my changes should have been affecting that to my knowledge and the checkboxes works fine manually or if you select them like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UAT: everything worked as expected.
Nice! More lines removed than added
Made a couple more small changes as requested here:
|
Closes PROD-1549, PROD-1552
Description Of Changes
Simplifies flow of adding vendors from consent configuration page with or without Compass.
Without Compass:
With Compass:
Code Changes
Steps to Confirm
From consent configuration page without Compass:
From consent configuration page with Compass:
Pre-Merge Checklist
CHANGELOG.md