Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 'add vendor' flow #4550

Merged
merged 13 commits into from
Jan 12, 2024
Merged

update 'add vendor' flow #4550

merged 13 commits into from
Jan 12, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jan 9, 2024

Closes PROD-1549, PROD-1552

Description Of Changes

Simplifies flow of adding vendors from consent configuration page with or without Compass.

Without Compass:

  • Consent configuration page shows consent management table
  • On clicking "Add vendors", single vendor add modal opens

With Compass:

  • Consent configuration page shows consent management table
  • On clicking "Add vendors", user is taken to bulk vendor add page
  • From that page, user can click "Add custom vendor" to open single vendor add modal with Compass suggestions enabled
  • When user's filters yield no results, a message is shown prompting the user to add a custom vendor

Code Changes

  • Removed old VendorCookieTable component and old consent configuration pages, replace with consent management table
  • Functionality in add vendor modal for editing is now unnecessary, so has been removed
  • Add vendor modal is now (without Compass) on the consent management table or (with Compass) on the bulk vendor add page; behavior of "Add vendors" button on consent management table changed to depend on Compass status

Steps to Confirm

From consent configuration page without Compass:

  • Should show consent management table
  • Click "Add vendors"
  • Should open single vendor add modal
  • Should be able to add and save a vendor

From consent configuration page with Compass:

  • Should show consent management table
  • Click "Add vendors"; should redirect to bulk vendor add table
  • Click "Add custom vendor" from bulk add table
  • Should open single vendor add modal with Compass enabled
  • Should be able to add and save Compass or non-Compass vendors

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 5:23pm

Copy link

cypress bot commented Jan 9, 2024

Passing run #5972 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge f675623 into 7efe458...
Project: fides Commit: 8691a882b6 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jan 12, 2024 5:32 PM Ended: Jan 12, 2024 5:32 PM

Review all test suite changes for PR #4550 ↗︎

cy.getByTestId("row-0").within(() => {
cy.get('[type="checkbox"]').check({ force: true });
});
cy.get('[type="checkbox"').check({ force: true });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is a workaround for some weird behavior with the previous .check() not checking the checkbox-- none of my changes should have been affecting that to my knowledge and the checkboxes works fine manually or if you select them like this.

@jpople jpople marked this pull request as ready for review January 9, 2024 17:41
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UAT: everything worked as expected.

Nice! More lines removed than added

@jpople
Copy link
Contributor Author

jpople commented Jan 12, 2024

Made a couple more small changes as requested here:

  • "Add" button no longer shows unless any systems are selected
  • Text is centered in "no results found" modal
  • Description ("Select your vendors below...") added back to top of "add multiple vendors" page

@jpople jpople merged commit 825d449 into main Jan 12, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-1549/update-vendor-add-flow branch January 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants