Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fides con 122 simon data erasure connector #4552

Merged
merged 20 commits into from
Mar 12, 2024

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Jan 10, 2024

Closes #CON-122

Description Of Changes

Added configuration, dataset, fixtures, and tests for Simon Data Erasure only connector

Code Changes

  • Added required config, dataset, test, fixtures and icon for Simon Data Erasure only connector

Pre-PR checklist

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Create an Access DSR with the identity value
  • Verify email sent by Fides with customer data is correct

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md
  • Icon

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 1:16pm

Copy link

cypress bot commented Jan 10, 2024

Passing run #6615 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ea21daa into 5eabf62...
Project: fides Commit: fa551683b5 ℹ️
Status: Passed Duration: 00:34 💡
Started: Mar 12, 2024 1:27 PM Ended: Mar 12, 2024 1:27 PM

Review all test suite changes for PR #4552 ↗︎

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (5eabf62) to head (ea21daa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4552   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files         336      336           
  Lines       20089    20089           
  Branches     2581     2581           
=======================================
  Hits        17413    17413           
  Misses       2203     2203           
  Partials      473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca marked this pull request as draft January 10, 2024 15:32
@MarcGEthyca
Copy link
Contributor Author

Still a couple of things to complete here but I wanted this available for review as I don't think they are going to impact the overall operation, e.g. I am working on getting the docs up and out, I still need to change the changelog as well.

@MarcGEthyca MarcGEthyca requested a review from galvana March 7, 2024 19:39
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with this one, the structure looks good and the tests all passed! I just left a few comments.

data/saas/config/simon_data_config.yml Show resolved Hide resolved
tests/fixtures/saas/simon_data_fixtures.py Show resolved Hide resolved
tests/ops/integration_tests/saas/test_simon_data_task.py Outdated Show resolved Hide resolved
@MarcGEthyca MarcGEthyca linked an issue Mar 8, 2024 that may be closed by this pull request
@MarcGEthyca MarcGEthyca requested a review from galvana March 8, 2024 19:08
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the changelog update and a question around the request body @MarcGEthyca - nice work here!

CHANGELOG.md Outdated Show resolved Hide resolved
data/saas/config/simon_data_config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @MarcGEthyca ! Thanks for following through on this, added one update suggestion for the changelog is all

CHANGELOG.md Show resolved Hide resolved
@SteveDMurphy SteveDMurphy mentioned this pull request Mar 11, 2024
12 tasks
@MarcGEthyca
Copy link
Contributor Author

MarcGEthyca commented Mar 12, 2024

Thanks to both @SteveDMurphy and @galvana for their reviews! I think we're all set except for the Vault setup and configuring. My local tests run without issue but while I can submit a request with Simon Data integration, I can't see the request to approve it at this point.

This was just a misunderstanding/misremembering on my part. Adrian sorted me out =)

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good to me!

@MarcGEthyca MarcGEthyca merged commit 92c9f52 into main Mar 12, 2024
42 checks passed
@MarcGEthyca MarcGEthyca deleted the fides-con-122-Simon-Data-Erasure-connector branch March 12, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimonData
3 participants