Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-9 Talkable Connector #4589

Merged
merged 13 commits into from
Feb 6, 2024
Merged

CON-9 Talkable Connector #4589

merged 13 commits into from
Feb 6, 2024

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Feb 2, 2024

Closes CON-9

Description Of Changes

This PR creates a connector for Talkable

Code Changes

  • Talkable SaaS config, dataset, and fixtures

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

@RobertKeyser RobertKeyser marked this pull request as draft February 2, 2024 16:39
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 8:12pm

@RobertKeyser RobertKeyser changed the title Con 9 talkable CON-9 Talkable Connector Feb 2, 2024
@RobertKeyser RobertKeyser self-assigned this Feb 2, 2024
Copy link

cypress bot commented Feb 2, 2024

Passing run #6182 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 1f31deb into 3bacb77...
Project: fides Commit: 00744c6e28 ℹ️
Status: Passed Duration: 00:34 💡
Started: Feb 2, 2024 7:43 PM Ended: Feb 2, 2024 7:44 PM

Review all test suite changes for PR #4589 ↗︎

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9604e9b) 86.80% compared to head (1f31deb) 86.80%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4589   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files         330      330           
  Lines       19858    19858           
  Branches     2550     2550           
=======================================
  Hits        17238    17238           
  Misses       2152     2152           
  Partials      468      468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobertKeyser RobertKeyser marked this pull request as ready for review February 5, 2024 19:18
@galvana galvana merged commit 0135810 into main Feb 6, 2024
18 checks passed
@galvana galvana deleted the CON-9-talkable branch February 6, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants