Ignore 404 - Kustomer and Delighted #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SteveDMurphy
force-pushed
the
SteveDMurphy-prod-1646-ignore-404-delighted-kustomer
branch
from
d4c1e20
to
43aaadf
Compare
Passing run #6483 ↗︎
Details:
Review all test suite changes for PR #4593 ↗︎ |
|||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4593 +/- ##
=======================================
Coverage 86.67% 86.67%
=======================================
Files 336 336
Lines 20090 20090
Branches 2581 2581
=======================================
Hits 17414 17414
Misses 2203 2203
Partials 473 473 ☔ View full report in Codecov by Sentry. |
galvana
requested changes
Feb 6, 2024
…-1646-ignore-404-delighted-kustomer
I don't know how this got so lost, but circling back finally @galvana 😅 |
galvana
approved these changes
Mar 5, 2024
SteveDMurphy
deleted the
SteveDMurphy-prod-1646-ignore-404-delighted-kustomer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-1646
Description Of Changes
An edge case found when an erasure for the same user is approved simultaneously, allowing the access portion to succeed (user found) but only one erasure to succeed while the other results in a 404.
As the desired result is to have the user no longer found, ignoring a 404 in this situation feels like the right course of action.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md