Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1617: Update when GPP API reports signal status: ready #4635

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Feb 27, 2024

Closes https://ethyca.atlassian.net/browse/PROD-1617

Description Of Changes

Update when GPP API reports signal status: ready

Code Changes

  • Set signal status to ready for users with no existing consent prefs when all notices are default opt-in
  • Update tests

Steps to Confirm

  • Run fidesplus
  • Run admin UI
  • Add a system with a data use of marketing.advertising.third_party.targeted. Give it any data category and a legal basis of “Consent”.
  • Visit /management/consent. Choose “national” or “state-by-state” and also set your MSPA values.
  • When you toggle between “national” and “state-by-state” you’ll get different privacy notices showing up in /consent/privacy-notices. Enable at least one of the GPP ones.
  • Set up a notice linked to that data use you've set up, with a geo in the US.
  • Run privacy center
  • Nav to http://localhost:3000/fides-js-demo.html?geolocation={{geo}}, using whatever geo you've configured in your notice
  • Confirm that when the banner shows, using __gpp('ping', (data) => {console.log({data})}) in the console produces a response that includes signalStatus: "ready":
Screenshot 2024-02-27 at 9 59 35 AM
  • Clear cookies, add a system / notice that is opt-out by default (e.g. data sales / sharing)
  • Confirm that when the banner shows, using __gpp('ping', (data) => {console.log({data})}) in the console produces a response that includes signalStatus: "not ready"

Pre-Merge Checklist

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 11:21pm

Copy link

cypress bot commented Feb 27, 2024

Passing run #6407 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ef9e092 into cc9409c...
Project: fides Commit: b487e610a2 ℹ️
Status: Passed Duration: 00:35 💡
Started: Feb 28, 2024 11:30 PM Ended: Feb 28, 2024 11:31 PM

Review all test suite changes for PR #4635 ↗︎

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Works as expected! Small caveat that it's not currently possible to test the scenario where we should be receiving not ready, due to there not being any GPP notices that are not default opt in.

@Kelsey-Ethyca Kelsey-Ethyca merged commit c00494c into main Feb 29, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-1617 branch February 29, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants