Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove location and regulation beta flag #4660

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Remove location and regulation beta flag #4660

merged 3 commits into from
Mar 8, 2024

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Mar 5, 2024 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/PROD-1747

Description Of Changes

Remove location and regulation beta flag so that the location page and the regulation

Steps to Confirm

  • look at beta flags page under management and verify the flag no longer exists
  • verify regulations and locations show in nav and can be access by an Owner and Contributor user role

Pre-Merge Checklist

@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 3:54pm

@cypress Cypress
Copy link

cypress bot commented Mar 5, 2024 •
edited
Loading

Passing run #6520 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 6854524 into f48a227...
Project: fides Commit: aa6a106c30 ℹ️
Status: Passed Duration: 00:35 💡
Started: Mar 6, 2024 4:04 PM Ended: Mar 6, 2024 4:05 PM

Review all test suite changes for PR #4660 ↗︎

jpople
jpople approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected ✅

@Kelsey-Ethyca Kelsey-Ethyca merged commit ef11403 into main Mar 8, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-1747-move-location-config-out-of-beta branch March 8, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpople jpople jpople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kelsey-Ethyca @jpople