Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterable Erasure Integration #4695

Merged
merged 17 commits into from
Apr 2, 2024
Merged

Iterable Erasure Integration #4695

merged 17 commits into from
Apr 2, 2024

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Mar 13, 2024

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • Erasure support for Iterable

Pre-PR checklist

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Create an Access DSR with the identity value
  • Verify email sent by Fides with customer data is correct

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • For API changes, the Postman collection has been updated
  • Update CHANGELOG.md

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 4:03pm

Copy link

cypress bot commented Mar 13, 2024

Passing run #7013 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge c8c9883 into 9c5dd34...
Project: fides Commit: 8d4b9aa05d ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 2, 2024 4:15 PM Ended: Apr 2, 2024 4:15 PM

Review all test suite changes for PR #4695 ↗︎

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (ec6cad0) to head (e1cbec3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4695      +/-   ##
==========================================
- Coverage   86.64%   86.64%   -0.01%     
==========================================
  Files         338      338              
  Lines       19993    19993              
  Branches     2555     2555              
==========================================
- Hits        17323    17322       -1     
  Misses       2201     2201              
- Partials      469      470       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca self-assigned this Mar 14, 2024
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments but overall this is looking good 👍

CHANGELOG.md Outdated Show resolved Hide resolved
data/saas/config/iterable_config.yml Show resolved Hide resolved
tests/fixtures/saas/iterable_fixtures.py Outdated Show resolved Hide resolved
tests/fixtures/saas/iterable_fixtures.py Show resolved Hide resolved
data/saas/icon/iterable.svg Outdated Show resolved Hide resolved
@MarcGEthyca MarcGEthyca requested a review from a team as a code owner March 28, 2024 15:08
CHANGELOG.md Outdated Show resolved Hide resolved
Fixed placement of addition

Co-authored-by: Adrian Galvan <[email protected]>
@MarcGEthyca MarcGEthyca merged commit 479a353 into main Apr 2, 2024
40 checks passed
@MarcGEthyca MarcGEthyca deleted the integration_iterable_ints-95 branch April 2, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants