Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE fixes related to experience config form #4707

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

eastandwestwind
Copy link
Contributor

Closes #

Description Of Changes

Fixes the following from https://ethyca.atlassian.net/wiki/spaces/PM/pages/2957672451/Product+UAT:

  • TCF Overlay missing some translation fields: Banner title, Banner description
  • Additional translation fields should be required: Save button label, Acknowledge button label
  • All optional translation fields should say “(optional)” for consistency: Banner title, Banner description, Privacy policy link label, Privacy policy link URL
  • Privacy Experience Config - Long property names overflow from the list container

Code Changes

  • Preview mode FE changes

Steps to Confirm

Pre-Merge Checklist

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 6:22pm

Copy link

cypress bot commented Mar 14, 2024

Passing run #6659 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge cbac9da into ef34c89...
Project: fides Commit: bbab928efb ℹ️
Status: Passed Duration: 00:37 💡
Started: Mar 14, 2024 6:33 PM Ended: Mar 14, 2024 6:34 PM

Review all test suite changes for PR #4707 ↗︎

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Working as expected!

@eastandwestwind eastandwestwind merged commit f2c7f93 into main Mar 14, 2024
13 checks passed
@eastandwestwind eastandwestwind deleted the catherine-fe-fixes branch March 14, 2024 18:35
@cypress cypress bot mentioned this pull request Mar 14, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants