Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acknowledge button label to default language form #4714

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Kelsey-Ethyca
Copy link
Contributor

Steps to Confirm

  • run fidesplus on the main branch with nox -s "build(slim)" "dev(slim)" -- dev
  • run this fide branch with cd clients && turbo run dev
  • nav to Experience page
  • click create new experience
  • click English
  • verify "Acknowledge" button label is populated with OK

Pre-Merge Checklist

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 10:25pm

Copy link

cypress bot commented Mar 14, 2024

Passing run #6696 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 85adef6 into 0a57252...
Project: fides Commit: b9b3891a69 ℹ️
Status: Passed Duration: 00:34 💡
Started: Mar 14, 2024 10:36 PM Ended: Mar 14, 2024 10:36 PM

Review all test suite changes for PR #4714 ↗︎

@Kelsey-Ethyca Kelsey-Ethyca merged commit 1b49c3b into main Mar 14, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the KT-add-acknowledge branch March 14, 2024 23:15
@cypress cypress bot mentioned this pull request Mar 14, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants