-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fides adyen erasure integration #4735
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #7015 ↗︎
Details:
Review all test suite changes for PR #4735 ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4735 +/- ##
==========================================
- Coverage 86.64% 86.62% -0.02%
==========================================
Files 338 339 +1
Lines 19993 20007 +14
Branches 2555 2556 +1
==========================================
+ Hits 17323 17332 +9
- Misses 2201 2206 +5
Partials 469 469 ☔ View full report in Codecov by Sentry. |
src/fides/api/service/saas_request/override_implementations/adyen_request_overrides.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor fix on the PSP references and we're good to go!
Fair! I thought I would leave it as it's named in the API docs, but this is better! Co-authored-by: Adrian Galvan <[email protected]>
Co-authored-by: Adrian Galvan <[email protected]>
Closes #INTS-60
Code Changes
Erasure support for Adyen
Pre-PR Checklist
Secrets added to 1Password
connector_params
identity_email
oridentity_phone_number
Postman collection
Documentation:
https://github.com/ethyca/fidesdocs/pull/345/
https://github.com/ethyca/fidesdocs/issues/346
https://ethyca.atlassian.net/wiki/spaces/EN/pages/2867363841/Adyen+Erasure+Integration+Spec
Pre-Merge Checklist
CHANGELOG.md
Steps to Confirm