Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fides adyen erasure integration #4735

Merged
merged 27 commits into from
Apr 2, 2024
Merged

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Mar 21, 2024

Closes #INTS-60

Code Changes

Erasure support for Adyen

  • integration files added, including an override for this case

Pre-PR Checklist

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Icon added
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • For API changes, the Postman collection has been updated
  • Update CHANGELOG.md

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Create an Access DSR with the identity value
  • Verify email sent by Fides with customer data is correct

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 5:59pm

Copy link

cypress bot commented Mar 21, 2024

Passing run #7015 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 3433d24 into 9c5dd34...
Project: fides Commit: 72972f5cf5 ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 2, 2024 4:16 PM Ended: Apr 2, 2024 4:16 PM

Review all test suite changes for PR #4735 ↗︎

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 86.62%. Comparing base (9c5dd34) to head (3433d24).
Report is 1 commits behind head on main.

Files Patch % Lines
...verride_implementations/adyen_request_overrides.py 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4735      +/-   ##
==========================================
- Coverage   86.64%   86.62%   -0.02%     
==========================================
  Files         338      339       +1     
  Lines       19993    20007      +14     
  Branches     2555     2556       +1     
==========================================
+ Hits        17323    17332       +9     
- Misses       2201     2206       +5     
  Partials      469      469              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca self-assigned this Mar 29, 2024
@MarcGEthyca MarcGEthyca marked this pull request as ready for review March 30, 2024 00:08
@MarcGEthyca MarcGEthyca requested a review from a team as a code owner March 30, 2024 00:08
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor fix on the PSP references and we're good to go!

data/saas/config/adyen_config.yml Outdated Show resolved Hide resolved
data/saas/config/adyen_config.yml Outdated Show resolved Hide resolved
MarcGEthyca and others added 3 commits April 2, 2024 11:59
Fair! I thought I would leave it as it's named in the API docs, but this is better!

Co-authored-by: Adrian Galvan <[email protected]>
@MarcGEthyca MarcGEthyca merged commit 05d8b25 into main Apr 2, 2024
13 of 14 checks passed
@MarcGEthyca MarcGEthyca deleted the fides-Adyen-Erasure-integration branch April 2, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants