Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1828: Cleanup config vars for preview in Admin-UI #4745

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Mar 26, 2024

Closes https://ethyca.atlassian.net/browse/PROD-1828

Description Of Changes

Removes unneeded configs for preview mode

Code Changes

  • Remove debug logging in preview mode
  • Remove unneeded fidesPreviewMode env var

Steps to Confirm

  • Confirm no regressions in preview mode in Admin-UI

Pre-Merge Checklist

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 6:47am

@eastandwestwind eastandwestwind changed the title Cleanup config vars for preview mode PROD-1828: Cleanup config vars for preview mode Mar 26, 2024
@eastandwestwind eastandwestwind changed the title PROD-1828: Cleanup config vars for preview mode PROD-1828: Cleanup config vars for preview in Admin-UI Mar 26, 2024
Copy link

cypress bot commented Mar 26, 2024

Passing run #6882 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c95e8d4 into e4ec5f7...
Project: fides Commit: c0992abf30 ℹ️
Status: Passed Duration: 00:34 💡
Started: Mar 27, 2024 6:57 AM Ended: Mar 27, 2024 6:58 AM

Review all test suite changes for PR #4745 ↗︎

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. It's so nice when you get to make the codebase smaller.

@eastandwestwind
Copy link
Contributor Author

Noting that the failing test cannot be replicated locally:

 1) localizes in the user selected locale (es)
      when ?fides_locale override param is set to an available locale (es)

@eastandwestwind eastandwestwind merged commit 19d0c70 into main Mar 27, 2024
11 of 13 checks passed
@eastandwestwind eastandwestwind deleted the PROD-1828 branch March 27, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants