Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show 'allow dismissal' toggle when editing TCF experience #4755

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Show 'allow dismissal' toggle when editing TCF experience #4755

merged 8 commits into from
Apr 2, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Mar 28, 2024

Closes PROD-1884, PROD-1871

Description Of Changes

  • Change label on toggle switch of "dismissable" toggle to "Allow user to dismiss"
  • Make switch visible while editing TCF overlay experience (should now be visible for any component except a privacy center)

Steps to Confirm

  • Edit the TCF overlay experience or create a new experience with any experience type except privacy center
  • "Allow user to dismiss" switch should show
  • Create a new privacy experience and set the experience type to privacy center
  • "Allow user to dismiss" switch should not show

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 3:17pm

@jpople jpople changed the title show 'allow dismissal' toggle when editing TCF experience Show 'allow dismissal' toggle when editing TCF experience Mar 28, 2024
@cypress Cypress
Copy link

cypress bot commented Mar 28, 2024 •
edited
Loading

Passing run #7010 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge ccdcf24 into 3ff188b...
Project: fides Commit: 7ba3650017 ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 2, 2024 3:29 PM Ended: Apr 2, 2024 3:29 PM

Review all test suite changes for PR #4755 ↗︎

@jpople jpople requested a review from lucanovera March 28, 2024 17:09
lucanovera
lucanovera approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! approve

@jpople jpople merged commit 9c5dd34 into main Apr 2, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-1884/tcf-allow-dismiss-toggle branch April 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucanovera lucanovera lucanovera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpople @lucanovera @NevilleS @gilluminate