Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing privacy request detail page #4775

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Apr 3, 2024

Closes PROD-1925

Description Of Changes

Fixing an issue with the PII component where it would not render if it received a number type as the data prop.

Code Changes

  • Updated PII component
  • Updated Cypress tests/fixtures to test custom privacy request field details rendering

Steps to Confirm

  • Send the following payload to fides
curl -X 'POST' \
  'http://localhost:8080/api/v1/privacy-request/authenticated' \
  -H 'accept: application/json' \
  -H 'Authorization: Bearer REDACTED\
  -H 'Content-Type: application/json' \
  -d '[
    {
        "external_id": "abc1234561",
        "identity": {
            "email": "[email protected]"
        },
        "custom_privacy_request_fields": {
            "userIDs": {
                "label": "User IDs",
                "value": 1234
            },
            "analyticsIDs": {
                "label": "Analytics IDs",
                "value": "abcd"
            }
        },
        "policy_key": "default_erasure_policy"
    }
]'
  • In the Admin UI, navigate to the request management page and click to view the details of the new request
  • The page should render correctly

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 3:53pm

@galvana galvana requested a review from NevilleS April 3, 2024 21:56
@galvana galvana marked this pull request as ready for review April 3, 2024 21:56
Copy link

cypress bot commented Apr 3, 2024

Passing run #7050 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 74d7bbc into 18fd8b7...
Project: fides Commit: 8afb6b7df9 ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 3, 2024 10:07 PM Ended: Apr 3, 2024 10:08 PM

Review all test suite changes for PR #4775 ↗︎

@galvana galvana merged commit 53bebf1 into main Apr 4, 2024
11 checks passed
@galvana galvana deleted the PROD-1925-fix-privacy-request-detail-page branch April 4, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants