Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to only label GVL vendors from compass as such #4857

Merged
merged 5 commits into from
May 2, 2024

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented May 2, 2024

Closes PROD-2019

Description Of Changes

Updates our determination of vendor source in the FE to more strictly check for a gvl. prefix in the vendor_id, rather than assuming any non-AC vendors are GVL vendors.

Code Changes

  • tweak logic in extractVendorSource

Steps to Confirm

  • locally things seemed good on some smoke testing, but it wasn't a comprehensive check to make sure i didn't break something...
  • i could use some more discerning eyes from a code and functionality perspective!

Pre-Merge Checklist

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 8:03pm

Copy link

cypress bot commented May 2, 2024

Passing run #7585 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 417c700 into 13a035f...
Project: fides Commit: 32fc59d0ae ℹ️
Status: Passed Duration: 00:35 💡
Started: May 2, 2024 8:13 PM Ended: May 2, 2024 8:14 PM

Review all test suite changes for PR #4857 ↗︎

@adamsachs adamsachs marked this pull request as ready for review May 2, 2024 20:17
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UAT ✅

@adamsachs adamsachs merged commit d1f6a0a into main May 2, 2024
13 checks passed
@adamsachs adamsachs deleted the asachs/PROD-2019-attempt branch May 2, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants