Remove response limit from fides.js #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…onse-Size-Limited-to-4MB-error-when-generating-large-fides.js-responses
Passing run #7690 ↗︎
Details:
Review all test suite changes for PR #4878 ↗︎ |
||||||||||||||||||||
…onse-Size-Limited-to-4MB-error-when-generating-large-fides.js-responses
galvana
approved these changes
May 10, 2024
There was a problem hiding this comment.
This works as expected! I added a long description to one of the banner descriptions and I was able to create a payload over 4MB in size from fides.js. The error doesn't actually prevent the download but removing this limit eliminates this false alarm that might cause concern for some users.
galvana
deleted the
PROD-2031-Privacy-Center-Fix-API-Routes-Response-Size-Limited-to-4MB-error-when-generating-large-fides.js-responses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #PROD-2031
Description Of Changes
By default Next.JS throws "API Routes Response Size Limited to 4MB" when the response is larger than 4MB, disabling this will not throw data in the console. But this can allow us to have very big responses without noticing anymore. From the Next.JS docs: API Routes in Next.js are designed to deliver quick responses and are not built to support the transmission of large amounts of data.
Code Changes
configvariable tofides-js.tsto change theapi.responseLimittofalseSteps to Confirm
scriptvariable onfides-js.tsfile to include a lot of comments, just 4MB of it, and you'll get a message on the dev web server shell. After this change gets into main, the message will be gone.Pre-Merge Checklist
CHANGELOG.md