Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix middleware logging to show only the information that is correct #4885

Merged
merged 7 commits into from
May 15, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #PROD-2033

Description Of Changes

Fix middleware logging to show only the information that is correct. The middleware tools provided by Next.JS are not enough for measuring the time it takes to process a request, and it is also not possible to capture the returned status code to the client.

Code Changes

  • Removed code that was logging deceptive information.

Steps to Confirm

  • Check that the logging output has been reduced to path and method.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 7:21pm

Copy link

cypress bot commented May 13, 2024

Passing run #7736 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge f8eadf4 into 0f9acea...
Project: fides Commit: 3418ad5c26 ℹ️
Status: Passed Duration: 00:35 💡
Started: May 15, 2024 12:16 AM Ended: May 15, 2024 12:17 AM

Review all test suite changes for PR #4885 ↗︎

@galvana galvana self-requested a review May 14, 2024 03:47
@galvana galvana merged commit faf56ad into main May 15, 2024
11 checks passed
@galvana galvana deleted the PROD-2033-fix-middleware-logging branch May 15, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants