Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fides ints 296 recurly add erasure #4891

Merged
merged 19 commits into from
May 23, 2024
Merged

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented May 15, 2024

Closes #

Description Of Changes

Added erasure to this existing integration

Code Changes

  • Added to the existing integration adding update endpoints, testing and fixture enhancements

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Create an Access DSR with the identity value
  • Verify email sent by Fides with customer data is correct

Pre-Merge Checklist

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 6:35pm

Copy link

cypress bot commented May 15, 2024

Passing run #7903 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a3b39d2 into f3b7d0d...
Project: fides Commit: b1baf71a30 ℹ️
Status: Passed Duration: 00:34 💡
Started: May 23, 2024 6:45 PM Ended: May 23, 2024 6:46 PM

Review all test suite changes for PR #4891 ↗︎

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (f3b7d0d) to head (a3b39d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4891   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files         347      347           
  Lines       21224    21224           
  Branches     2784     2784           
=======================================
  Hits        18423    18423           
  Misses       2312     2312           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca marked this pull request as ready for review May 23, 2024 13:19
@MarcGEthyca MarcGEthyca requested a review from a team as a code owner May 23, 2024 13:20
@MarcGEthyca MarcGEthyca requested a review from galvana May 23, 2024 14:13
@MarcGEthyca MarcGEthyca self-assigned this May 23, 2024
@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label May 23, 2024
@MarcGEthyca MarcGEthyca merged commit b9e6afe into main May 23, 2024
45 of 48 checks passed
@MarcGEthyca MarcGEthyca deleted the fides_ints_296_recurly_add_erasure branch May 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants