Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Cloud SQL MySQL Connector #4949
Google Cloud SQL MySQL Connector #4949
Changes from 8 commits
7785f1e
4e59a66
d52fb51
e0d0101
40c0168
de71c40
b745c69
3f3fa9a
4e71a1c
0dc27df
6979b27
2109ed3
f19cfe8
60bd835
67fe4ea
7de7c14
ab5c6a1
54aa62f
b7bdc8e
f856d1c
a24cad9
73530c8
77a8b4f
6c16fdc
3c0e61b
ca5943a
04110cc
0fb4f91
09c0a7a
1c2a3c9
cb46034
7f3bc61
da682bf
b59ee98
e6ba1a3
4a5f3d4
a9fec2a
286afac
f99cf3f
b0392a3
e62fcab
5458b89
58f188c
ace74df
4b0cce9
bfb908a
fb5f3ca
347dad0
659f0cc
00d36bf
8e87792
43bea8e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll notice there's a few
Static-Checks
failures in the pipeline https://github.com/ethyca/fides/actions/runs/9405253983/job/25905996405?pr=4949. You can avoid this by runningnox -s static_checks
locally and addressing any Mypy or Pylint errors before pushing up your changes. This should take care of all the formatting changes in this and other files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be using Google's
keyfile_creds
similar to how we do it inconnection_secrets_bigquery
. Take a look at option two in this doc for how to authenticate using a keyfile https://ethyca.atlassian.net/wiki/spaces/EN/pages/3029204995/2024-04-19+Google+Cloud+SQL+Integration#Option-2-(IAM-database-authentication)