remove unnecessary ending slash (/) in endpoint URLs #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #8215 ↗︎
Details:
Review all test suite changes for PR #4962 ↗︎ |
||||||||||||||||||||
galvana
approved these changes
Jun 10, 2024
|
@galvana Probably not worth the time to try to enforce URL string patterns in endpoint calls. If I had to guess, someone did it once on accident and others mimicked. We'll see if the pattern returns, but I'm hopeful it's a fluke. |
gilluminate
force-pushed
the
gill/PROD-2178_many-endpoints-directed-toward
branch
from
256bf96
to
71c20be
Compare
Passing run #8221 ↗︎
Details:
Review all test suite changes for PR #4962 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2178
Description Of Changes
Many of our endpoints in Fides Admin UI are pointing at a URL unnecessarily ending with
/which ends up being redirected in the browser behind the scenes to the same URL without it.Fixing these URLs in the code is a quick way to optimize our response time!
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md