Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change textarea for keyfile credentials to password input #4971

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jun 10, 2024

Closes PROD-2186

Description Of Changes

Masks "Keyfile credentials" input on new "create integration" form so credentials are not visible.

Screenshot 2024-06-10 at 17 11 09

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 7:33pm

Copy link

cypress bot commented Jun 10, 2024

Passing run #8259 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a827d68 into e555181...
Project: fides Commit: b576f761d0 ℹ️
Status: Passed Duration: 00:34 💡
Started: Jun 11, 2024 7:41 PM Ended: Jun 11, 2024 7:41 PM

Review all test suite changes for PR #4971 ↗︎

@jpople jpople merged commit 28df71f into main Jun 12, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2186/mask-credentials-input branch June 12, 2024 15:31
Copy link

cypress bot commented Jun 12, 2024

Passing run #8270 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Change textarea for keyfile credentials to password input (#4971)
Project: fides Commit: 28df71f862
Status: Passed Duration: 00:34 💡
Started: Jun 12, 2024 3:42 PM Ended: Jun 12, 2024 3:43 PM

Review all test suite changes for PR #4971 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants