Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fetch polyfill from FidesJS #5026

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Remove fetch polyfill from FidesJS #5026

merged 2 commits into from
Jun 27, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jun 26, 2024

Description Of Changes

No need to continue supporting browsers without fetch capabilities.
See https://caniuse.com/?search=fetch

Code Changes

  • Remove polyfill that was used to supplement fetch when browsers didn't support it.

Steps to Confirm

  • For the scope of this change, we only need to ensure that no regressions occur using your default / standard browser and all pre-existing functionality with the cookie banner is not broken.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 11:43pm

@gilluminate gilluminate changed the title Remove fetch polyfill Remove fetch polyfill from FidesJS Jun 26, 2024
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. window.fetch is fully supported, so this is basically an unused code branch anyways 😄

Copy link

cypress bot commented Jun 26, 2024

Passing run #8552 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c2e2497 into 1f464b5...
Project: fides Commit: 3906ace603 ℹ️
Status: Passed Duration: 00:34 💡
Started: Jun 26, 2024 11:54 PM Ended: Jun 26, 2024 11:55 PM

Review all test suite changes for PR #5026 ↗︎

@gilluminate gilluminate merged commit 868c4d6 into main Jun 27, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/remove-polyfill branch June 27, 2024 00:00
Copy link

cypress bot commented Jun 27, 2024

Passing run #8553 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Remove fetch polyfill from FidesJS (#5026)
Project: fides Commit: 868c4d6297
Status: Passed Duration: 00:36 💡
Started: Jun 27, 2024 12:12 AM Ended: Jun 27, 2024 12:12 AM

Review all test suite changes for PR #5026 ↗︎

@cypress cypress bot mentioned this pull request Jun 28, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants