Upgrade React version in all clients #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #8817 ↗︎
Details:
Review all test suite changes for PR #5036 ↗︎ |
||||||||||||||||||||
gilluminate
changed the title
gilluminate
commented
Jun 28, 2024
| @@ -190,7 +190,6 @@ const PrivacyNoticeTranslationForm = ({ | |||
| as={HStack} | |||
| spacing={8} | |||
| align="start" | |||
| grow={1} | |||
There was a problem hiding this comment.
this wasn't getting caught before, but is now. there is no grow prop
Comment on lines
+12
to
+13
| description?: string; | ||
| name?: string; |
There was a problem hiding this comment.
these actually aren't always being set, which is causing errors
Comment on lines
-29
to
-34
| type ManualAccessProcessingDetailProps = { | ||
| connectorName: string; | ||
| data: ManualInputData; | ||
| isSubmitting: boolean; | ||
| onSaveClick: (params: PatchUploadManualWebhookDataRequest) => void; | ||
| }; |
There was a problem hiding this comment.
Exporting this from ./types now to be able to share it with ManualProcessingList.tsx
| @@ -13,10 +12,6 @@ import { | |||
| } from "./user-management.slice"; | |||
| import UserManagementRow from "./UserManagementRow"; | |||
|
|
|||
| interface UsersTableProps { | |||
| users?: User[]; | |||
There was a problem hiding this comment.
was no longer used
gilluminate
force-pushed
the
PROD-2076-upgrade-react-version-in-all
branch
from
4cc8db3
to
eea0362
Compare
gilluminate
force-pushed
the
PROD-2076-upgrade-react-version-in-all
branch
from
eea0362
to
e9ad6e3
Compare
gilluminate
force-pushed
the
PROD-2076-upgrade-react-version-in-all
branch
from
89d8c55
to
ca8887b
Compare
Next no longer uses babel. See https://nextjs.org/docs/messages/swc-disabled
gilluminate
force-pushed
the
PROD-2076-upgrade-react-version-in-all
branch
from
3f2c033
to
dec1bb3
Compare
This reverts commit dec1bb3.
gilluminate
force-pushed
the
PROD-2076-upgrade-react-version-in-all
branch
from
fc7669c
to
f87b21d
Compare
jpople
reviewed
Jul 9, 2024
jpople
approved these changes
Jul 9, 2024
Passing run #8818 ↗︎
Details:
Review all test suite changes for PR #5036 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2076
Description Of Changes
Upgrade to React 18 along will all dependencies which need upgrading as a result.
Code Changes
React.FCpatterns and using Chakra v2sisDisabledfor buttons)Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md