Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-5076] - Changed webserver URL to correct URL #5088

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

farmanp
Copy link
Contributor

@farmanp farmanp commented Jul 16, 2024

Closes (#5076)

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • Changed URL to correct URL

Steps to Confirm

  • Confirmed with product management this was the correct deployment link

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jul 16, 2024

@servis is attempting to deploy a commit to the Ethyca Team on Vercel.

A member of the Team first needs to authorize it.

@pattisdr
Copy link
Contributor

Thanks very much for this improvement @farmanp! Do you mind getting this up to date with main again so we can merge? The CHANGELOG gets out of date quickly!

@farmanp
Copy link
Contributor Author

farmanp commented Jul 17, 2024

The branch is up to date @pattisdr! Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@farmanp farmanp requested a review from pattisdr July 17, 2024 14:43
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.48%. Comparing base (9f87c2e) to head (7a61c7c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5088   +/-   ##
=======================================
  Coverage   86.48%   86.48%           
=======================================
  Files         357      357           
  Lines       22271    22271           
  Branches     2944     2944           
=======================================
  Hits        19261    19261           
  Misses       2495     2495           
  Partials      515      515           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@farmanp
Copy link
Contributor Author

farmanp commented Jul 17, 2024

@servis is attempting to deploy a commit to the Ethyca Team on Vercel.

A member of the Team first needs to authorize it.

@pattisdr Do I need to take any further action or will you or a team member be merging this PR?

@pattisdr pattisdr merged commit dc3de5b into ethyca:main Jul 17, 2024
42 of 43 checks passed
@pattisdr
Copy link
Contributor

Merged! Thanks again for your contribution 🎉

Copy link

cypress bot commented Jul 17, 2024

Passing run #8965 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

[ISSUE-5076] - Changed webserver URL to correct URL (#5088)
Project: fides Commit: dc3de5b17c
Status: Passed Duration: 00:35 💡
Started: Jul 17, 2024 3:31 PM Ended: Jul 17, 2024 3:31 PM

Review all test suite changes for PR #5088 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants