-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project selection UX improvements #5092
Project selection UX improvements #5092
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #8980 ↗︎
Details:
Review all test suite changes for PR #5092 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code and the UI looks good. Tested inclusions, exclusions, select all.
My one suggestion is to change the copy "Selecting a project will monitor all current and future datasets found" to clarify that it means to monitor within that selected project.
Passing run #8981 ↗︎
Details:
Review all test suite changes for PR #5092 ↗︎ |
Closes PROD-2317
Description Of Changes
Changes appearance and behavior of project selection modal in discovery monitor form.
Do not merge until #5080 and Plus #2316 are merged.
Demo Loom
Code Changes
Steps to Confirm
Testing with this is a bit tricky without appropriate data-- I've mostly been using a hook which mocks a set of paginated responses with the same API as
useCumulativeGetDatabases
.databases
field of the response bodyexcluded_databases
fielddatabases
andexcluded_databases
should be emptyPre-Merge Checklist
CHANGELOG.md