Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project selection UX improvements #5092

Merged
merged 15 commits into from
Jul 17, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 17, 2024

Closes PROD-2317

Description Of Changes

Changes appearance and behavior of project selection modal in discovery monitor form.

Do not merge until #5080 and Plus #2316 are merged.

Demo Loom

Code Changes

  • Changed modal to use "infinite" query
  • Changed usePaginatedPicker behavior to be able to "select all" then cherry-pick a finite list of exclusions (previous behavior only allowed finite list of selections or "select all")

Steps to Confirm

Testing with this is a bit tricky without appropriate data-- I've mostly been using a hook which mocks a set of paginated responses with the same API as useCumulativeGetDatabases.

  • Set up a BigQuery integration with appropriate credentials
  • Create a monitor
  • Should be able to select some number of projects; on submission selected projects should be in the databases field of the response body
  • Should also be able to "select all" then deselect some number of projects; on submission deselected projects should be in the excluded_databases field
  • Should also be able to "select all"; on submission both databases and excluded_databases should be empty
  • Should be able to do all the above when editing an existing monitor also

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@jpople jpople added the do not merge Please don't merge yet, bad things will happen if you do label Jul 17, 2024
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 7:27pm

Copy link

cypress bot commented Jul 17, 2024

Passing run #8980 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c72408c into e4a1cfa...
Project: fides Commit: 3cc3c06854 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 17, 2024 7:35 PM Ended: Jul 17, 2024 7:36 PM

Review all test suite changes for PR #5092 ↗︎

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and the UI looks good. Tested inclusions, exclusions, select all.
My one suggestion is to change the copy "Selecting a project will monitor all current and future datasets found" to clarify that it means to monitor within that selected project.

@jpople jpople merged commit 235bb74 into main Jul 17, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2187/project-selection-ux-improvements branch July 17, 2024 19:42
Copy link

cypress bot commented Jul 17, 2024

Passing run #8981 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Project selection UX improvements (#5092)
Project: fides Commit: 235bb74ad9
Status: Passed Duration: 00:38 💡
Started: Jul 17, 2024 7:53 PM Ended: Jul 17, 2024 7:53 PM

Review all test suite changes for PR #5092 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Please don't merge yet, bad things will happen if you do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants