Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice to old system integrations page #5097

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 18, 2024

Closes PROD-2374

Description Of Changes

Changes text on old system integrations tab to direct to new integrations menu for D&D:

Screenshot 2024-07-18 at 12 42 49

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:29pm

Copy link

cypress bot commented Jul 18, 2024

Passing run #9058 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge aec2b80 into 40ab56a...
Project: fides Commit: f4825e1d8d ℹ️
Status: Passed Duration: 00:37 💡
Started: Jul 22, 2024 6:36 PM Ended: Jul 22, 2024 6:37 PM

Review all test suite changes for PR #5097 ↗︎

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor text change suggestion

Comment on lines 224 to 229
Add an integration to start managing privacy requests and consent.
Navigate{" "}
<Link href={INTEGRATION_MANAGEMENT_ROUTE} color="purple.500">
here
</Link>{" "}
to set up monitoring on databases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"here" is generally frowned upon as link text. Can we link something more semantic?

Suggested change
Add an integration to start managing privacy requests and consent.
Navigate{" "}
<Link href={INTEGRATION_MANAGEMENT_ROUTE} color="purple.500">
here
</Link>{" "}
to set up monitoring on databases.
Add an integration to start managing privacy requests and consent
<Link href={INTEGRATION_MANAGEMENT_ROUTE} color="purple.500">
Visit Integration Management
</Link>{" "}
to set up monitoring on databases.

@jpople jpople force-pushed the jpople/prod-2374/integrations-tab-notice branch from 4e35b48 to aec2b80 Compare July 22, 2024 18:25
@jpople jpople merged commit 8312146 into main Jul 22, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2374/integrations-tab-notice branch July 22, 2024 18:37
Copy link

cypress bot commented Jul 22, 2024

Passing run #9060 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Add notice to old system integrations page (#5097)
Project: fides Commit: 8312146964
Status: Passed Duration: 00:34 💡
Started: Jul 22, 2024 6:48 PM Ended: Jul 22, 2024 6:49 PM

Review all test suite changes for PR #5097 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants