Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for special characters in SaaS request body #5099

Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jul 18, 2024

Closes PROD-2377

Description Of Changes

We're seeing this error when sending non-Latin-1 characters (1234 Peterson’s Farm Rd.)

'latin-1' codec can't encode character '\u2019' in position 73: Body ('’') is not valid Latin-1. Use body.encode('utf-8') if you want to send it encoded in UTF-8.

This is because the Requests library uses Latin-1 as the default encoding for string bodies. The fix is to call encode("utf-8") on the request body.

Code Changes

  • Updated AuthenticatedClient and logger_context_utils.py

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 28, 2024 1:43am

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Jul 18, 2024
Copy link

cypress bot commented Jul 18, 2024

Passing run #9172 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a162787 into 7259f7d...
Project: fides Commit: 099d9606d5 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 28, 2024 1:55 AM Ended: Jul 28, 2024 1:56 AM

Review all test suite changes for PR #5099 ↗︎

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (14211e3) to head (d9e7512).

Files Patch % Lines
src/fides/api/util/logger_context_utils.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5099      +/-   ##
==========================================
- Coverage   86.56%   86.56%   -0.01%     
==========================================
  Files         357      357              
  Lines       22349    22354       +5     
  Branches     2955     2958       +3     
==========================================
+ Hits        19347    19351       +4     
  Misses       2480     2480              
- Partials      522      523       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana marked this pull request as ready for review July 19, 2024 01:50
@galvana galvana requested a review from a team as a code owner July 19, 2024 01:50
@galvana galvana merged commit 7977269 into main Jul 28, 2024
14 checks passed
@galvana galvana deleted the PROD-2377-special-character-support-for-saas-integrations branch July 28, 2024 01:44
Copy link

cypress bot commented Jul 28, 2024

Passing run #9173 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Adding support for special characters in SaaS request body (#5099)
Project: fides Commit: 7977269e8d
Status: Passed Duration: 00:37 💡
Started: Jul 28, 2024 1:55 AM Ended: Jul 28, 2024 1:56 AM

Review all test suite changes for PR #5099 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants