-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for special characters in SaaS request body #5099
Merged
galvana
merged 11 commits into
main
from
PROD-2377-special-character-support-for-saas-integrations
Jul 28, 2024
Merged
Adding support for special characters in SaaS request body #5099
galvana
merged 11 commits into
main
from
PROD-2377-special-character-support-for-saas-integrations
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
galvana
added
the
run unsafe ci checks
Runs fides-related CI checks that require sensitive credentials
label
Jul 18, 2024
Passing run #9172 ↗︎
Details:
Review all test suite changes for PR #5099 ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5099 +/- ##
==========================================
- Coverage 86.56% 86.56% -0.01%
==========================================
Files 357 357
Lines 22349 22354 +5
Branches 2955 2958 +3
==========================================
+ Hits 19347 19351 +4
Misses 2480 2480
- Partials 522 523 +1 ☔ View full report in Codecov by Sentry. |
galvana
commented
Jul 19, 2024
andres-torres-marroquin
approved these changes
Jul 25, 2024
galvana
deleted the
PROD-2377-special-character-support-for-saas-integrations
branch
July 28, 2024 01:44
Passing run #9173 ↗︎
Details:
Review all test suite changes for PR #5099 ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2377
Description Of Changes
We're seeing this error when sending non-Latin-1 characters (
1234 Peterson’s Farm Rd.
)This is because the
Requests
library usesLatin-1
as the default encoding for string bodies. The fix is to callencode("utf-8")
on the request body.Code Changes
AuthenticatedClient
andlogger_context_utils.py
Pre-Merge Checklist
CHANGELOG.md