Fix bug with changing monitor frequency from scheduled to "not scheduled" #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Passing run #9126 ↗︎
Details:
Review all test suite changes for PR #5114 ↗︎ |
||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5114 +/- ##
==========================================
+ Coverage 86.54% 86.56% +0.02%
==========================================
Files 357 357
Lines 22345 22349 +4
Branches 2954 2955 +1
==========================================
+ Hits 19339 19347 +8
+ Misses 2482 2480 -2
+ Partials 524 522 -2 ☔ View full report in Codecov by Sentry. |
erosselli
approved these changes
Jul 24, 2024
Comment on lines
+209
to
+211
| if execution_frequency == MonitorFrequency.NOT_SCHEDULED: | ||
| data["monitor_execution_trigger"] = None | ||
| return |
There was a problem hiding this comment.
Maybe we can add a case to the parameters of the test test_create_monitor_config_execution_trigger_logic so that we cover this line , what do you think?
There was a problem hiding this comment.
actually I see you did this already, unsure why codecov's reporting that these lines aren't covered
Passing run #9130 ↗︎
Details:
Review all test suite changes for PR #5114 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2305
Description Of Changes
Fixes a bug where discovery monitors that were scheduled for execution couldn't have their execution frequency changed to "not scheduled".
The issue was that the backend was treating a value of "undefined" for
execution_frequencyas "not scheduled", but the frontend isn't able to explicitly send "undefined" in its API request's payload. To fix, added aNOT_SCHEDULEDoption to the MonitorFrequency enum and updated form on frontend and validation on backend to handle it as an explicit value.Code Changes
NOT_SCHEDULEDto MonitorFrequency enumundefinedwhen "Not scheduled" is selected in the formSteps to Confirm
Must run Plus backend on branch
jpople/prod-2305/not-scheduled-edit-fix(see here)Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works