Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in bigquery monitor copy #5120

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix typo in bigquery monitor copy #5120

merged 2 commits into from
Jul 22, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jul 22, 2024

Closes PROD-2381

Description Of Changes

Updates the bigquery.projects.get permission to be resourcemanager.projects.get, which is the correct google cloud permission.

Steps to Confirm

  • Visit BigQuery integration details page and click both instances of "show more" to reveal the text. Verify that the property name is now correct.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 8:59pm

Copy link

cypress bot commented Jul 22, 2024

Passing run #9075 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 9ac2f84 into 8312146...
Project: fides Commit: 951109ec94 ℹ️
Status: Passed Duration: 00:34 💡
Started: Jul 22, 2024 9:09 PM Ended: Jul 22, 2024 9:10 PM

Review all test suite changes for PR #5120 ↗︎

@gilluminate gilluminate merged commit ce8b1b0 into main Jul 22, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/typo-fixes branch July 22, 2024 21:18
Copy link

cypress bot commented Jul 22, 2024

Passing run #9078 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix typo in bigquery monitor copy (#5120)
Project: fides Commit: ce8b1b031a
Status: Passed Duration: 00:34 💡
Started: Jul 22, 2024 9:28 PM Ended: Jul 22, 2024 9:29 PM

Review all test suite changes for PR #5120 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants