Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2366 - Admin UI for Managing OpenID Providers #5134

Merged
merged 68 commits into from
Aug 9, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Jul 29, 2024

Closes #PROD-2366

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • Add Admin UI for management of OpenID Providers.
  • Add flag for enabling or disabling OpenID Authentication.
  • Add support for creating users without password, when the OpenID Authentication flag is on, and we have SSO Providers setup.

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:17pm

@andres-torres-marroquin
Copy link
Contributor Author

Migrations are yet missing for this one.

@@ -82,8 +82,6 @@ def pylint(session: nox.Session) -> None:
"""Run the 'pylint' code linter."""
install_requirements(session)
command = ("pylint", "src", "noxfiles", "noxfile.py", "--jobs", "0")
if session.posargs:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing some problem on migrations + pylint.

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Andres! The UI looks great now! This will be very useful. I just left you a quick note about a page title.

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Approved!

@andres-torres-marroquin andres-torres-marroquin merged commit d0daed3 into main Aug 9, 2024
51 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the PROD-2366 branch August 9, 2024 20:57
Copy link

cypress bot commented Aug 9, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit d0daed3
Started Aug 9, 2024 9:08 PM
Ended Aug 9, 2024 9:09 PM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants