Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional toast for D&D table actions #5182

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Aug 12, 2024

Closes PROD-2482

Description Of Changes

Adds a success toast when confirming a classification on a D&D item.

Screenshot 2024-08-12 at 17 17 52

Code Changes

  • Add success toast when confirming
  • Remove unused "Remove" action button

Steps to Confirm

  • Confirm a resource from "Activity" and "Data discovery" tables
  • Should see success toast for both

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 8:48pm

Copy link

cypress bot commented Aug 12, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 702cc7a ℹ️
Started Aug 13, 2024 8:58 PM
Ended Aug 13, 2024 8:58 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@jpople jpople merged commit f8f23a7 into main Aug 14, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2482/new-dnd-toasts branch August 14, 2024 04:12
Copy link

cypress bot commented Aug 14, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit f8f23a7
Started Aug 14, 2024 4:24 AM
Ended Aug 14, 2024 4:25 AM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants