Bing Ads Integration #5197
Merged
Bing Ads Integration #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5197/merge
|
| Run status |
|
| Run duration | 00m 36s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5197 +/- ##
==========================================
- Coverage 86.41% 85.95% -0.46%
==========================================
Files 362 363 +1
Lines 22792 22955 +163
Branches 3060 3081 +21
==========================================
+ Hits 19695 19732 +37
- Misses 2538 2663 +125
- Partials 559 560 +1 ☔ View full report in Codecov by Sentry. |
TBD: Set up the correct architecture on fides for the script
Considering ifan empty Audience List is a Fail State or not. We might not want to raise an Exception on these case, but fail silently? To consider. Leaving a Comment
Moving the Fixture CSV to the proper Location
We have a tracking ID as a response that we do not use yet, We might want to use it on the future
Updated on Authenticated Client. Since its an Optional Parameter, and its on the end, we should not have problems with this change
if they dont comply to the expect format, we wont get a result from the relevant fields. Thus there was an error with the response. response.text should yield the XML string containing the Error description from the endpoint
Still with some problems in local. The configuration is not being sent properly
We might want to do a deeper Error handling, as there acan be detailed errors on the SOAP Structure
Updating Test, using the real reference
galvana
commented
Aug 28, 2024
| @@ -26,6 +26,7 @@ class SaaSRequestParams(BaseModel): | |||
| headers: Dict[str, Any] = {} | |||
| query_params: Dict[str, Any] = {} | |||
| body: Optional[str] = None | |||
| files: Optional[list] = None | |||
There was a problem hiding this comment.
Can we use a more specific type hint here? How about this?
RequestFile = Tuple[str, Tuple[str, IO, str]]
...
class SaaSRequestParams(BaseModel):
"""
Holds the method, path, headers, query, and body params to build a SaaS HTTP request.
"""
method: HTTPMethod
path: str
headers: Dict[str, Any] = {}
query_params: Dict[str, Any] = {}
body: Optional[str] = None
files: Optional[List[RequestFile]] = None
model_config = ConfigDict(use_enum_values=True, arbitrary_types_allowed=True)
| method: GET | ||
| client_config: | ||
| protocol: https | ||
| host: login.microsoftonline.com |
There was a problem hiding this comment.
Make sure we have the prod versions before we commit this version
|
|
||
| connector_params: | ||
| - name: domain | ||
| default_value: clientcenter.api.sandbox.bingads.microsoft.com # change to the prod URL for the default |
There was a problem hiding this comment.
Let's change this to the prod default value and remove the comment
galvana
added
the
run unsafe ci checks
Vagoasdf
approved these changes
Aug 28, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes INTS-164
Description Of Changes
We're adding a new Integration with Microsoft's Bing Ads Network. This allows us to remove the emails of users from the Audience's Customer List of our clients. At the time of development, this is the only PII avaliable on the microsoft Advertising Network
Since the API is SOAP based, we had to do some changes to the saas connector and schemas, in order to accept files
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md