Classifier category badge updates

[jpople]

Closes PROD-2546

Description Of Changes

Visual update to data category badges and status badges in discovery field tables and tweaks to behavior.

Old:

New:

Behavior changes:

• Status now shows "reviewed" instead of "pending review" when user has assigned any data categories
• Classifier-assigned data categories now show a sparkle icon in their badge
• Add category button now appears when category is "None", except on nested fields (the server 400s when trying to update a category on a field with subfields, as only terminal-level fields are supposed to have data categories)

Code Changes

• Refactor result status badge and classification badge components

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Issue Requirements are Met
• Update CHANGELOG.md

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)	Visit Preview		Aug 20, 2024 6:59pm

[cypress]

---

Test summary

4 • 0 • 0 • 0

---

Run details

Project	fides
Status	Passed
Commit	6c45300 ℹ️
Started	Aug 20, 2024 7:11 PM
Ended	Aug 20, 2024 7:12 PM
Duration	00:36 💡
OS	Linux Ubuntu -
Browser	Electron 106

View run in Cypress Cloud ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

[lucanovera]

Looks much cleaner now. I found no bugs with the UI. I think it's a bit odd that when you delete a category it goes back to the classification result, but I guess that's helpful if you accidentally change the category and want to go back. I wasn't able to test the None state because of that, but I see that you've added a test to cover that.

Everything looks good. Just needs the changelog update. I will leave the approve now.

[jpople]

I think it's a bit odd that when you delete a category it goes back to the classification result, but I guess that's helpful if you accidentally change the category and want to go back. I wasn't able to test the None state because of that, but I see that you've added a test to cover that.

Yeah, this behavior is a bit strange but I talked it over with Adam, Kirk and Jack last week and it seems like there's no way around it for now without extra backend changes, and we don't ever want to fully get rid of the classifier data categories. The None state where the field doesn't have subfields shouldn't ever happen TMK, just wanted it covered in case I'm failing to think of something.

[cypress]

---

Test summary

4 • 0 • 0 • 0

---

Run details

Project	fides
Status	Passed
Commit	60d005e
Started	Aug 20, 2024 7:48 PM
Ended	Aug 20, 2024 7:49 PM
Duration	00:35 💡
OS	Linux Ubuntu -
Browser	Electron 106

View run in Cypress Cloud ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud