Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2606 Add-support-for-nested-fields-in-Dataset-Field-Detail-page #5216

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Aug 20, 2024

Description Of Changes

Add support for navigating/editing nested fields in the Datasets page.

Code Changes

  • Created a dataset fields page, that can be used for any nested level using a urn query param
  • In all edit drawers, moved the delete icon to the bottom left and removed the Cancel button that was there
  • Added semibold to column name for everything row that can be clicked
  • Reorganized the dataset page files to make query params more clear /dataset/[datasetId]/[collectionName]/[subfieldUrn]
  • Added tests for subfields
  • Updated the fields edit drawer to use a new helper getDatasetPath and lodash's get/set/unset properties for easier updating of the dataset object
  • Removed unused code after Dataset page refactor / Remove old code from classification functionality now part of D&D

Steps to Confirm

  • Go to Datasets and add a new datasets with nested fields (this one works https://github.com/ethyca/fides/blob/main/data/dataset/mongo_example_test_dataset.yml)
  • Check that the dataset table now includes semibold in column names
  • Check that you can navigate down into the nested field level
  • Check that the breadcrumbs show the correct level of navigation and icon
  • Check that the search filters correctly
  • Check that you can add/remove data categories using the picker
  • Check that you can use the edit drawer to edit the description and/or data categories
  • Check that the delete button works and it is now placed in the bottom left of the edit drawer

Screenshots

Screen Shot 2024-08-20 at 11 35 29
Screen Shot 2024-08-20 at 11 35 33
Screen Shot 2024-08-20 at 11 35 37
Screen Shot 2024-08-20 at 11 35 41

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 6:56pm

Copy link

cypress bot commented Aug 20, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 13759fa ℹ️
Started Aug 20, 2024 7:05 PM
Ended Aug 20, 2024 7:05 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming 404 issue is fixed-- looks good!

…port-for-nested-fields-in-Dataset-Field-Detail-page
@lucanovera lucanovera merged commit 3d69cf1 into main Aug 21, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2606-Add-support-for-nested-fields-in-Dataset-Field-Detail-page branch August 21, 2024 15:08
Copy link

cypress bot commented Aug 21, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 3d69cf1
Started Aug 21, 2024 3:21 PM
Ended Aug 21, 2024 3:21 PM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants