Add "data type" column to D&D tables

[jpople]

Closes PROD-2379

Description Of Changes

Adds a "data type" column to fields in D&D tables.

Code Changes

• Regenerate types
• Refactor D&D table cells; collect them all in one directory and change some names for consistency

Steps to Confirm

Running fidesplus backend on branch https://github.com/ethyca/fidesplus/pull/1567/files, "Data type" column should appear on fields in D&D result tables.

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Issue Requirements are Met
• Update CHANGELOG.md

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 21, 2024 1:54pm

[cypress]

---

Test summary

4 • 0 • 0 • 0

---

Run details

Project	fides
Status	Passed
Commit	5b09692 ℹ️
Started	Aug 21, 2024 2:12 PM
Ended	Aug 21, 2024 2:12 PM
Duration	00:37 💡
OS	Linux Ubuntu -
Browser	Electron 106

View run in Cypress Cloud ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

[lucanovera]

Nice job organizing the files. I see the data type column correctly in the Data Detection portion.

But no values appear in the Data Discovery column, looking at the response from the API I see that the source_data_type is null but the data_type says string. So I wonder if this is a backend issue or is it expected to get it as data_type and that should be the fallback value to source_data type in the FE.

Also, I saw you removed the "--" fallback for description in the useDetectionResultColumns on line 124 but it is still there in other parts of the file and in useDiscoveryResultColumns too, we'll probably want to keep a consistency there.

[jpople]

@lucanovera

I saw you removed the "--" fallback for description in the useDetectionResultColumns on line 124 but it is still there in other parts of the file and in useDiscoveryResultColumns too, we'll probably want to keep a consistency there.

Thanks for catching this, fixed.

But no values appear in the Data Discovery column, looking at the response from the API I see that the source_data_type is null but the data_type says string. So I wonder if this is a backend issue or is it expected to get it as data_type and that should be the fallback value to source_data type in the FE.

This was a backend and frontend issue-- I was querying the wrong field and the backend was returning null for the right field (source_data_type is correct). It should be resolved, try pulling the latest and you should see source_data_type populated in both detection and discovery tables.

[lucanovera]

@lucanovera

I saw you removed the "--" fallback for description in the useDetectionResultColumns on line 124 but it is still there in other parts of the file and in useDiscoveryResultColumns too, we'll probably want to keep a consistency there.

Thanks for catching this, fixed.

But no values appear in the Data Discovery column, looking at the response from the API I see that the source_data_type is null but the data_type says string. So I wonder if this is a backend issue or is it expected to get it as data_type and that should be the fallback value to source_data type in the FE.

This was a backend and frontend issue-- I was querying the wrong field and the backend was returning null for the right field (source_data_type is correct). It should be resolved, try pulling the latest and you should see source_data_type populated in both detection and discovery tables.

Thanks for the updates. I just tested with the latest from BE and FE branches and I see the data types correctly.

[lucanovera]

Approved!

[cypress]

---

Test summary

4 • 0 • 0 • 0

---

Run details

Project	fides
Status	Passed
Commit	8333be1
Started	Aug 21, 2024 4:27 PM
Ended	Aug 21, 2024 4:28 PM
Duration	00:38 💡
OS	Linux Ubuntu -
Browser	Electron 106

View run in Cypress Cloud ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud