FidesJS sourcemaps working correctly #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
| customFidesCss | ||
| ? ` | ||
| // Include custom fides.css styles | ||
| // keep fidesJS on the first line to avoid sourcemap issues! |
eastandwestwind
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Manually tested and confirmed source maps and breakpoints are working great! Thanks for this huge improvement to dev workflow @gilluminate !
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourcemaps for
fides.jsandfides-tcf.jsare now functional with this change. GPP doesn't work, but since nothing worked before, this is a huge improvement.Clicking from console logs etc. will take you to the correct source in the browser. Setting breakpoints is now possible.
Code Changes
Pre-Merge Checklist
CHANGELOG.md