Support new Purpose header field in TCF Banner #5247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
gilluminate
force-pushed
the
PROD-2699-tcf-banner-subtitle
branch
2 times, most recently
from
c2ba770
to
38f3e1c
Compare
gilluminate
commented
Aug 29, 2024
| @@ -162,7 +163,24 @@ export const getTranslationFormFields = ( | |||
| modal_link_label: { included: true }, | |||
| }; | |||
| } | |||
| // For TCF overlay / default | |||
|
|
|||
| if (component === ComponentType.TCF_OVERLAY) { | |||
There was a problem hiding this comment.
TCF is different enough from default now, that it felt warranted to create its own section like the ones above
| @@ -117,6 +118,7 @@ function extractMessagesFromExperienceConfig( | |||
| const locale = experienceConfig.language || DEFAULT_LOCALE; | |||
| const messages: Messages = {}; | |||
| EXPERIENCE_TRANSLATION_FIELDS.forEach((key) => { | |||
| // @ts-expect-error EXPERIENCE_TRANSLATION_FIELDS is a const array | |||
There was a problem hiding this comment.
unrelated fix, just to get rid of the error message in VS Code.
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5247/merge
|
| Run status |
|
| Run duration | 00m 36s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
gilluminate
force-pushed
the
PROD-2699-tcf-banner-subtitle
branch
from
38f3e1c
to
cdd15e4
Compare
gilluminate
changed the title
gilluminate
changed the title
eastandwestwind
approved these changes
Aug 30, 2024
| @@ -162,7 +163,24 @@ export const getTranslationFormFields = ( | |||
| modal_link_label: { included: true }, | |||
| }; | |||
| } | |||
| // For TCF overlay / default | |||
|
|
|||
| if (component === ComponentType.TCF_OVERLAY) { | |||
|
Tested locally alongside https://github.com/ethyca/fidesplus/pull/1589, this is looking good.
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2699
Description Of Changes
Code Changes
Steps to Confirm
http://localhost:3001/fides-js-demo.html?geolocation=eea)Pre-Merge Checklist
NOTE: since this will be hotfixed in the current release, no separate entry in the CHANGELOG is needed.