PROD-2701 Fix no monitor button on empty tables #5249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
added 2 commits
August 30, 2024 09:53
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5249/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Lucano Vera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
…table-in-Data-Detection
jpople
approved these changes
Aug 30, 2024
lucanovera
deleted the
PROD-2701-No-action-button-to-monitor-empty-table-in-Data-Detection
branch
lucanovera
added a commit
that referenced
this pull request
Aug 30, 2024
Co-authored-by: Lucano Vera <[email protected]>
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Lucano Vera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fix no monitor button appearing on empty tables.
The problem was caused because the FE was trying to figure out the resource type based off the nested resource content. This caused a problem with empty tables causing it to think that it was a Field and therefore not showing a Monitor icon. The BE now returns a resource_type so we should use that instead. I still left the other code as a fallback since resource_type is listed as an optional property.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md