Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand/Collapse Data Categories #5265

Merged
merged 13 commits into from
Sep 6, 2024
Merged

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Sep 6, 2024

Closes PROD-2677

Description Of Changes

On the Datamap Reporting table

  • New overflow indicator that represents how many categories are hidden after displaying the first 2
  • Update badge styles for Data uses and Data categories columns
  • User can expand each cell individually by clicking the overflow indicator
  • User can collapse each cell individually by clicking anywhere in the cell
  • Update the header menu:
    • Rename options to "Expand all" and "Collapse all"
    • Reorder so that "Expand all" is first
    • add a "Wrap results" checkbox option
  • Update all badges in this table to be hidden if there are 0 results
  • Adjust table column resize handle to be more user friendly

Steps to Confirm

  • Visit Datamap report page in Admin UI /reporting/datamap
  • Ensure that Data categories are collapsed by default (may need to visit in incognito window in case expand/collapse has been saved in Local Storage already for you)
  • Expand a couple of individual cells by clicking the overflow indicator (eg. "+5 more")
  • Open the header menu of the Data categories column
    • Click "Collapse all" to ensure the individual cells you expanded above are collapsed again
    • Click "Expand all" and ensure that all badges appear in this column and are stacked by default
    • Click "Wrap results" checkbox to see that all expanded badges are now wrapping within the cell space rather than stacked
  • Drag the column resizer to change width of the Data categories column and ensure badges wrap to the cell width as expected
  • Open the column options again, uncheck "Wrap results", and ensure the badges are now stacked within each cell
  • Play around with Expand/Collapse/Wrap in various combinations of those states to ensure resulting behavior is expected.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 7:48pm

Copy link

cypress bot commented Sep 6, 2024

fides    Run #9841

Run Properties:  status check passed Passed #9841  •  git commit f6a2bb96ac ℹ️: Merge 17f27b2e56f0ecadbb0a6db90f10927542644308 into 8d2d787b83b21bb1301bb5cf4239...
Project fides
Branch Review refs/pull/5265/merge
Run status status check passed Passed #9841
Run duration 00m 36s
Commit git commit f6a2bb96ac ℹ️: Merge 17f27b2e56f0ecadbb0a6db90f10927542644308 into 8d2d787b83b21bb1301bb5cf4239...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@gilluminate gilluminate force-pushed the PROD-2677-fe-expand-collapse-data branch from 53d1a91 to 302f87f Compare September 6, 2024 19:41
@jack-gale-ethyca
Copy link

Well done, this is a massive improvement to our reporting tables.

Copy link

@jack-gale-ethyca jack-gale-ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great.

@gilluminate gilluminate merged commit 6be5adc into main Sep 6, 2024
22 checks passed
@gilluminate gilluminate deleted the PROD-2677-fe-expand-collapse-data branch September 6, 2024 20:24
Copy link

cypress bot commented Sep 6, 2024

fides    Run #9842

Run Properties:  status check passed Passed #9842  •  git commit 6be5adc0f3: Expand/Collapse Data Categories (#5265)
Project fides
Branch Review main
Run status status check passed Passed #9842
Run duration 00m 38s
Commit git commit 6be5adc0f3: Expand/Collapse Data Categories (#5265)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants