Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROD-2698: clarify permissions needed for GCP #5266

Merged
merged 2 commits into from
Sep 11, 2024
Merged

PROD-2698: clarify permissions needed for GCP #5266

merged 2 commits into from
Sep 11, 2024

Conversation

eastandwestwind
Copy link
Contributor

Closes https://ethyca.atlassian.net/browse/PROD-2698

Description Of Changes

Update Info text in Admin-UI for Google Cloud SQL for Postgres

Code Changes

  • update copy

Steps to Confirm

  • Run plus with detection & discovery enabled, pointed to this branch
  • Create discovery monitor for Google Cloud SQL for postgres
  • Confirm Info text contains the following permissions:
cloudsql.instances.connect
cloudsql.instances.get
cloudsql.instances.login

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 7:55pm

@cypress Cypress
Copy link

cypress bot commented Sep 6, 2024 •
edited
Loading

fides    Run #9840

Run Properties:  status check passed Passed #9840  •  git commit a29120e495 ℹ️: Merge 8be5d630c24b8972e35fa8178f3154d14bd9ca63 into 8d2d787b83b21bb1301bb5cf4239...
Project fides
Branch Review refs/pull/5266/merge
Run status status check passed Passed #9840
Run duration 00m 39s
Commit git commit a29120e495 ℹ️: Merge 8be5d630c24b8972e35fa8178f3154d14bd9ca63 into 8d2d787b83b21bb1301bb5cf4239...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

andres-torres-marroquin
andres-torres-marroquin approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@andres-torres-marroquin andres-torres-marroquin merged commit 240d8fd into main Sep 11, 2024
13 checks passed
@cypress Cypress
Copy link

cypress bot commented Sep 11, 2024

fides    Run #9903

Run Properties:  status check passed Passed #9903  •  git commit 240d8fd8ac: PROD-2698: clarify permissions needed for GCP (#5266)
Project fides
Branch Review main
Run status status check passed Passed #9903
Run duration 00m 36s
Commit git commit 240d8fd8ac: PROD-2698: clarify permissions needed for GCP (#5266)
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andres-torres-marroquin andres-torres-marroquin andres-torres-marroquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eastandwestwind @andres-torres-marroquin