Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC Postgres Row-Level Deletes #5276

Closed
wants to merge 1 commit into from
Closed

POC Postgres Row-Level Deletes #5276

wants to merge 1 commit into from

Conversation

pattisdr
Copy link
Contributor

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Sep 11, 2024 0:07am

@pattisdr pattisdr changed the title POC Row-Level Deletes POC Postgres Row-Level Deletes Sep 11, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 11, 2024

fides    Run #9879

Run Properties:  status check failed Failed #9879  •  git commit 9cf19c467e ℹ️: Merge 65dfd23ebcf52f4f7b61c511126ca1d70e6dc93f into 523a17ae61d56e609b210ed2d5ba...
Project fides
Branch Review refs/pull/5276/merge
Run status status check failed Failed #9879
Run duration 01m 22s
Commit git commit 9cf19c467e ℹ️: Merge 65dfd23ebcf52f4f7b61c511126ca1d70e6dc93f into 523a17ae61d56e609b210ed2d5ba...
Committer Dawn Pattison
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/smoke_test.cy.ts • 1 failed test

View Output Video

Test Artifacts
Smoke test > can submit an access request from the Privacy Center Screenshots Video

@pattisdr
Copy link
Contributor Author

POC branch replaced with #5293

@pattisdr pattisdr closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pattisdr