Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate FE Types #5284

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Regenerate FE Types #5284

wants to merge 1 commit into from

Conversation

pattisdr
Copy link
Contributor

Closes #PROD-2746

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

… configured_regions. Other changes picked up alongside.
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ❌ Failed (Inspect) Sep 13, 2024 1:07am

Comment on lines -11 to -12
aggregated_score?: number | null;
classification_paradigm?: string | null;
Copy link
Contributor Author

@pattisdr pattisdr Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK this has been removed from the backend and will cause FE issues - I'm going to reticket

./src/features/dataset/EditCollectionOrFieldForm.tsx:58:19
Type error: Property 'aggregated_score' does not exist on type 'Classification'.

  56 |       );
  57 |       return classifyField.classifications.map(
> 58 |         ({ label, aggregated_score }) => {
     |                   ^
  59 |           const dc = dataCategoryMap.get(label);
  60 |
  61 |           return {

@pattisdr pattisdr changed the title Regenerate FE Types after Aliasing Change around Privacy Notices Regenerate FE Types Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant