Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<WIP> Make user endpoints synchronous #5285

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erosselli
Copy link
Contributor

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Sep 13, 2024 1:05pm

@erosselli erosselli changed the title Make user endpoints synchronous <WIP> Make user endpoints synchronous Sep 13, 2024
Copy link

cypress bot commented Sep 13, 2024

fides    Run #9947

Run Properties:  status check passed Passed #9947  •  git commit da2fbd231a ℹ️: Merge b991bf362279769708aece00768c9670fc203e1d into b6dee79e00eb050ed51b82f26377...
Project fides
Branch Review refs/pull/5285/merge
Run status status check passed Passed #9947
Run duration 00m 35s
Commit git commit da2fbd231a ℹ️: Merge b991bf362279769708aece00768c9670fc203e1d into b6dee79e00eb050ed51b82f26377...
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant