Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate FE Types around Privacy Notice Aliases #5290

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Regenerate FE Types around Privacy Notice Aliases #5290

merged 5 commits into from
Sep 17, 2024

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Sep 16, 2024 •
edited by jira bot
Loading

Closes PROD-2746

Description Of Changes

New types generated from https://github.com/ethyca/fidesplus/pull/1611

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 1:09am

@pattisdr pattisdr marked this pull request as ready for review September 16, 2024 20:55
@cypress Cypress
Copy link

cypress bot commented Sep 16, 2024 •
edited
Loading

fides    Run #9960

Run Properties:  status check passed Passed #9960  •  git commit 894243821b ℹ️: Merge ea029bee08c193594583acbbad4319342e09d5b6 into ac1c84aef0259962a2e8980e1a69...
Project fides
Branch Review refs/pull/5290/merge
Run status status check passed Passed #9960
Run duration 00m 36s
Commit git commit 894243821b ℹ️: Merge ea029bee08c193594583acbbad4319342e09d5b6 into ac1c84aef0259962a2e8980e1a69...
Committer Dawn Pattison
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Sep 16, 2024
@pattisdr pattisdr merged commit 31bc63a into main Sep 17, 2024
13 checks passed
@pattisdr pattisdr deleted the fe_regenerate_types branch September 17, 2024 02:28
pattisdr added a commit that referenced this pull request Sep 17, 2024
@pattisdr @galvana
Regenerate FE Types around Privacy Notice Aliases (#5290)
c43bb75 
Co-authored-by: Adrian Galvan <[email protected]>
@cypress Cypress
Copy link

cypress bot commented Sep 17, 2024

fides    Run #9961

Run Properties:  status check passed Passed #9961  •  git commit 31bc63a2a2: Regenerate FE Types around Privacy Notice Aliases (#5290)
Project fides
Branch Review main
Run status status check passed Passed #9961
Run duration 00m 35s
Commit git commit 31bc63a2a2: Regenerate FE Types around Privacy Notice Aliases (#5290)
Committer Dawn Pattison
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Vagoasdf pushed a commit that referenced this pull request Sep 24, 2024
@pattisdr @galvana @Vagoasdf
Regenerate FE Types around Privacy Notice Aliases (#5290)
2e4759d 
Co-authored-by: Adrian Galvan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattisdr @galvana